Skip to content

SRA async chunk encoding and v4 signing #6514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 28, 2025
Merged

SRA async chunk encoding and v4 signing #6514

merged 11 commits into from
Oct 28, 2025
+1,151 −379

Conversation

@dagnir
Copy link
Contributor

@dagnir dagnir commented Oct 23, 2025 •
edited
Loading

Motivation and Context

Revert 39dd680 after making sure s3-tests are running correctly.

The only new change from original commit (#6500) is including all the bucket types in the set of test configs: 6889e54

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

dagnir added 3 commits October 23, 2025 13:02
@dagnir
Remove echo command
b58ca8e 
Ensures the CB job fails if the `mvn` command fails.
@dagnir
Revert "Revert "Release async chunk encoding and Sigv4 signing in Def…
15684bb 
…aultAwsV4HttpSigner (#6500)""

This reverts commit 39dd680.
@dagnir
Merge PR 6512
f92b163
@dagnir dagnir requested a review from a team as a code owner October 23, 2025 21:49
@dagnir dagnir changed the title [WIP] SRA chunk encoding and v4 signing [WIP] SRA async chunk encoding and v4 signing Oct 23, 2025
@dagnir dagnir changed the title [WIP] SRA async chunk encoding and v4 signing SRA async chunk encoding and v4 signing Oct 24, 2025
@dagnir
Run payload signing tests
88f403c 
We don't force payload signing for `http` endpoints, but it's possible
to enable payload signing now by for `https` endpoints.
@dagnir dagnir enabled auto-merge October 27, 2025 17:34
@dagnir dagnir added this pull request to the merge queue Oct 27, 2025
@dagnir dagnir removed this pull request from the merge queue due to a manual request Oct 27, 2025
dagnir added a commit that referenced this pull request Oct 27, 2025
@dagnir
Bump minor version to 2.37.0
400c13f 
Prepping to release

 - #6494
 - #6514
@dagnir dagnir mentioned this pull request Oct 27, 2025
Merged
12 tasks
@dagnir dagnir added this pull request to the merge queue Oct 27, 2025
@dagnir dagnir removed this pull request from the merge queue due to a manual request Oct 27, 2025
@dagnir dagnir enabled auto-merge October 27, 2025 23:04
@dagnir dagnir added this pull request to the merge queue Oct 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 28, 2025
@zoewangg zoewangg enabled auto-merge October 28, 2025 01:34
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zoewangg zoewangg added this pull request to the merge queue Oct 28, 2025
Merged via the queue into master with commit 00f9188 Oct 28, 2025
47 of 49 checks passed
@github-actions
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zoewangg zoewangg zoewangg approved these changes

@RanVaknin RanVaknin RanVaknin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dagnir @zoewangg @RanVaknin